Re: [PATCH] firmware: smccc: set variables smccc_soc_id_version,revision storage-class-specifier to static

[Sudeep Holla]

On Sun, Apr 23, 2023 at 11:34:28AM -0400, Tom Rix wrote:
> smatch reports
> drivers/firmware/smccc/smccc.c:20:21: warning: symbol
>   'smccc_soc_id_version' was not declared. Should it be static?
> drivers/firmware/smccc/smccc.c:21:21: warning: symbol
>   'smccc_soc_id_revision' was not declared. Should it be static?
> 
> These variables are only used in their defining file so should be static
>

Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>

Since the patch introducing this issue comes from irqchip tree, we must
either route this through that if they have earlier fixes set or wait
until v6.4-rc1 and send it through SoC tree. Please cc soc@xxxxxxxxxx and
Marc Z and repost. It is better to be explicit and mention it is either
based on -next or mention the commit introducing the issue since it make
no sense if one has no knowledge of -next change.

-- 
Regards,
Sudeep