Re: [PATCH][next] rv: remove redundant assignment to variable retval

From: Daniel Bristot de Oliveira
Date: Mon Apr 24 2023 - 05:20:46 EST


On 4/18/23 17:00, Colin Ian King wrote:
> Variable retval is being assigned a value that is never read, it is
> being re-assigned a new value in both paths of a following if statement.
> Remove the assignment.
>
> Cleans up clang-scan warning:
> kernel/trace/rv/rv.c:293:2: warning: Value stored to 'retval' is never read [deadcode.DeadStores]
> retval = count;
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Acked-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>

Thanks!
-- Daniel