Re: [PATCH v2 8/8] mfd: max77658: Add ADI MAX77643/54/58/59 MFD Support

[Lee Jones]

On Sun, 23 Apr 2023, Arslanbenzer, Zeynep wrote:

> On Thu, 30 Mar 2023, Lee Jones wrote:
> 
> >On Wed, 22 Mar 2023, Zeynep Arslanbenzer wrote:
> >
> >> MFD driver for MAX77643/MAX77654/MAX77658/MAX77659 to enable its sub
> >
> >Please drop all references to 'MFD'.
> >
> >What are these devices, really?  I suspect they are PMICs?
> >
> >> devices.
> >>
> >> The MAX77643 is a multi-function devices. It includes regulator.
> >>
> >> The MAX77654 is a multi-function devices. It includes regulator and 
> >> charger.
> >>
> >> The MAX77658 is a multi-function devices. It includes regulator, 
> >> charger and battery.
> >>
> >> The MAX77659 is a multi-function devices. It includes regulator and 
> >> charger.
> >>
> >> Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@xxxxxxxxxx>
> >> Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@xxxxxxxxxx>
> >> ---
> >>  drivers/mfd/Kconfig          |  15 ++
> >>  drivers/mfd/Makefile         |   1 +
> >>  drivers/mfd/max77658.c       | 448 +++++++++++++++++++++++++++++++++++
> >>  include/linux/mfd/max77658.h |  88 +++++++
> >>  4 files changed, 552 insertions(+)
> >>  create mode 100644 drivers/mfd/max77658.c  create mode 100644 
> >> include/linux/mfd/max77658.h
> >>
> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 
> >> 8b93856de432..7b4be7fb8662 100644
> >> --- a/drivers/mfd/Kconfig
> >> +++ b/drivers/mfd/Kconfig
> >> @@ -821,6 +821,21 @@ config MFD_MAX77650
> >>  	  the following functionalities of the device: GPIO, regulator,
> >>  	  charger, LED, onkey.
> >>
> >> +config MFD_MAX77658
> >> +	tristate "Analog Devices MAX77643/MAX77654/MAX77658/MAX77659 PMIC Support"
> >> +	depends on I2C
> >> +	depends on OF
> >> +	select MFD_CORE
> >> +	select REGMAP_I2C
> >> +	select REGMAP_IRQ
> >> +	help
> >> +	  Say Y here to add support for Analog Devices
> >> +	  MAX77643/MAX77654/MAX77658/MAX77659 Power Management IC.
> >
> >"MAX776xx series"?
> 
> As I realized later, max77620, max77650, max77686, and max77693 drivers were merged to Linux before our patch. They are also PMIC devices and our patch does not cover them. Therefore, I think it would not be appropriate to use MAX776xx.

Perhaps you can come up with something a little more scalable then.

What if you added support for another 10 devices?

-- 
Lee Jones [李琼斯]