Re: [PATCH] drivers: w1: slaves: Drop unnecessary explicit casting

[Krzysztof Kozlowski]

On 20/04/2023 02:21, Anup Sharma wrote:
> Provide correct specifiers while printing error logs to discard the use
> of unnecessary explicit casting.
> 
> Signed-off-by: Anup Sharma <anupnewsmail@xxxxxxxxx>
> ---
>  drivers/w1/slaves/w1_ds2433.c  | 6 +++---
>  drivers/w1/slaves/w1_ds28e04.c | 8 ++++----
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c
> index 0f72df15a024..ba441d42b0b0 100644
> --- a/drivers/w1/slaves/w1_ds2433.c
> +++ b/drivers/w1/slaves/w1_ds2433.c
> @@ -213,15 +213,15 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,
>  #ifdef CONFIG_W1_SLAVE_DS2433_CRC
>  	/* can only write full blocks in cached mode */
>  	if ((off & W1_PAGE_MASK) || (count & W1_PAGE_MASK)) {
> -		dev_err(&sl->dev, "invalid offset/count off=%d cnt=%zd\n",
> -			(int)off, count);
> +		dev_err(&sl->dev, "invalid offset/count off=%pe cnt=%zd\n",
> +			off, count);

I don't think you tested this patch. Why do you think off is a pointer?

Best regards,
Krzysztof