RE: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl configuration

From: Alim Akhtar
Date: Sun Apr 23 2023 - 01:06:34 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Saturday, April 22, 2023 12:32 AM
> To: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar
> <alim.akhtar@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl
> configuration
>
> The camera's pinctrl configuration is simply empty and not effective.
> Remove it to fix dtbs_check warnings like:
>
> s5pv210-torbreck.dtb: camera@fa600000: pinctrl-0: True is not of type
> 'array'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> arch/arm/boot/dts/s5pv210.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi
> b/arch/arm/boot/dts/s5pv210.dtsi index d9436bbf77c8..faa3682ab5dd
> 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -549,8 +549,6 @@ i2c1: i2c@fab00000 {
>
> camera: camera@fa600000 {
> compatible = "samsung,fimc";
> - pinctrl-names = "default";
> - pinctrl-0 = <>;
> clocks = <&clocks SCLK_CAM0>, <&clocks
> SCLK_CAM1>;
> clock-names = "sclk_cam0", "sclk_cam1";
> #address-cells = <1>;
> --
> 2.34.1