Re: [PATCH V7 3/3] rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support

From: Trilok Soni
Date: Sat Apr 22 2023 - 15:53:03 EST


On 4/22/2023 3:42 AM, Sarannya S wrote:
From: Chris Lew <quic_clew@xxxxxxxxxxx>

Add RPMSG_GET_OUTGOING_FLOWCONTROL and RPMSG_SET_INCOMING_FLOWCONTROL
IOCTL support for rpmsg char device nodes to get/set the low level
transport signals.

Signed-off-by: Chris Lew <quic_clew@xxxxxxxxxxx>
Signed-off-by: Deepak Kumar Singh <quic_deesin@xxxxxxxxxxx>
Signed-off-by: Sarannya S <quic_sarannya@xxxxxxxxxxx>

[...]

static const struct file_operations rpmsg_eptdev_fops = {
diff --git a/include/uapi/linux/rpmsg.h b/include/uapi/linux/rpmsg.h
index 1637e68..c955e27 100644
--- a/include/uapi/linux/rpmsg.h
+++ b/include/uapi/linux/rpmsg.h
@@ -10,7 +10,6 @@
#include <linux/types.h>
#define RPMSG_ADDR_ANY 0xFFFFFFFF
-

What is need of deleting this line in this patch? I am not sure if this was asked in earlier reviews.

---Trilok Soni