Re: [PATCH v3 0/3] Enable rk3588 timer support

[Cristian Ciocaltea]

On 4/22/23 16:17, Vincent Legoll wrote:
> Hello,
> 
> On Wed, Apr 19, 2023 at 6:13 PM Cristian Ciocaltea
> <cristian.ciocaltea@xxxxxxxxxxxxx> wrote:
>> This patchset enables Rockchip RK3588/RK3588S SoC timer support.
>> While here, it also handles a minor DT binding issue related to RK3288.
> 
> I tested this on a QuartzPro64 dev board, I applied your series top of my tree:
> Collabora's rk3588 + some DT patches to add support for the qp64 board.
> 
> Here is the output from the commands you told me to try:
> 
> bash-5.1# grep rk_timer /sys/bus/clockevents/devices/*/current_device
> /sys/bus/clockevents/devices/broadcast/current_device:rk_timer
> 
> bash-5.1# grep -B3 -A14 'Device: rk_timer' /proc/timer_list
> 
> Tick Device: mode:     1
> Broadcast device
> Clock Event Device: rk_timer
>  max_delta_ns:   178956969070
>  min_delta_ns:   1000
>  mult:           51539608
>  shift:          31
>  mode:           3
>  next_event:     150944000000 nsecs
>  set_next_event: rk_timer_set_next_event
>  shutdown:       rk_timer_shutdown
>  periodic:       rk_timer_set_periodic
>  event_handler:  tick_handle_oneshot_broadcast
> 
>  retries:        0
> 
> tick_broadcast_mask: ff
> 
> bash-5.1# head -1 /proc/interrupts ; grep rk_timer /proc/interrupts;
> sleep 10; grep rk_timer /proc/interrupts
>            CPU0       CPU1       CPU2       CPU3       CPU4       CPU5
>       CPU6       CPU7
>  25:        742        210         52         49       2197       1640
>       1089       2341     GICv3 321 Level     rk_timer
>  25:        754        222         52         49       2252       1727
>       1146       2404     GICv3 321 Level     rk_timer
> 
> So it looks like this is working.
> 
> Thanks for your work.
> 
> You can add my:
> 
> Tested-by: Vincent Legoll <vincent.legoll@xxxxxxxxx>

Thanks for taking the time to test this!

Regards,
Cristian