Re: [PATCH v2] hv/hv_kvp_daemon: Add support for keyfile config based connection profile in NM

[Olaf Hering]

Sat, 22 Apr 2023 01:39:43 -0700 Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>:

> The next part of this support is to let the Distro vendors consume
> these modified implementations to the new configuration format.

The approach taken here makes it difficult to consume the changes.
The way it is implemented means a given variant of the daemon produces
either ifcfg or .nmconnection files. In practice there is a single
source of hv_kvp_daemon.c which is compatible with all versions of a distro.

IMO the new feature should be implemented such that hv_kvp_daemon 
writes both files. Then the tooling can decide which of the files will
actually be used.


I think the configuration file for NetworkManager should have the
suffix .nmconnection, even if it may not be mandatory.

Olaf

Attachment: pgpnfQd17r4SJ.pgp
Description: Digitale Signatur von OpenPGP