Re: [RFC 2/8] shmem: convert to use folio_test_hwpoison()

From: Luis Chamberlain
Date: Fri Apr 21 2023 - 23:05:29 EST


On Fri, Apr 21, 2023 at 11:42:53PM +0100, Matthew Wilcox wrote:
> On Fri, Apr 21, 2023 at 02:43:54PM -0700, Luis Chamberlain wrote:
> > The PageHWPoison() call can be converted over to the respective folio call
> > folio_test_hwpoison(). This introduces no functional changes.
>
> Um, no. Nobody should use folio_test_hwpoison(), it's a nonsense.
>
> Individual pages are hwpoisoned. You're only testing the head page
> if you use folio_test_hwpoison(). There's folio_has_hwpoisoned() to
> test if _any_ page in the folio is poisoned. But blindly converting
> PageHWPoison to folio_test_hwpoison() is wrong.

Thanks! I don't see folio_has_hwpoisoned() though.

Luis