Re: [RFC PATCH net-next 02/22] net: dsa: mt7530: use p5_interface_select as data type for p5_intf_sel

[Arınç ÜNAL]

On 21.04.2023 19:23, Daniel Golle wrote:
> On Fri, Apr 21, 2023 at 05:36:28PM +0300, arinc9.unal@xxxxxxxxx wrote:
> > From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> >
> > Use the p5_interface_select enumeration as the data type for the
> > p5_intf_sel field. This ensures p5_intf_sel can only take the values
> > defined in the p5_interface_select enumeration.
> >
> > Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> > ---
> >   drivers/net/dsa/mt7530.h | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h
> > index 845f5dd16d83..703f8a528317 100644
> > --- a/drivers/net/dsa/mt7530.h
> > +++ b/drivers/net/dsa/mt7530.h
> > @@ -674,13 +674,13 @@ struct mt7530_port {
> >   };
> >   
> >   /* Port 5 interface select definitions */
> > -enum p5_interface_select {
> > -	P5_DISABLED = 0,
> > +typedef enum {
>
> We usually avoid adding typedef in kernel code. If the purpose is
> just to be more verbose in the struct definition, you can as well
> also just use 'enum p5_interface_select as type in the struct.
>
> > +	P5_DISABLED,
> >   	P5_INTF_SEL_PHY_P0,
> >   	P5_INTF_SEL_PHY_P4,
> >   	P5_INTF_SEL_GMAC5,
> >   	P5_INTF_SEL_GMAC5_SGMII,
> > -};
> > +} p5_interface_select;
> >   
> >   struct mt7530_priv;
> >   
> > @@ -768,7 +768,7 @@ struct mt7530_priv {
> >   	bool			mcm;
> >   	phy_interface_t		p6_interface;
> >   	phy_interface_t		p5_interface;
> > -	unsigned int		p5_intf_sel;
> > +	p5_interface_select	p5_intf_sel;
>
> enum p5_interface_select	p5_intf_sel;

Will do, thanks.

Arınç