Re: [PATCH v7 1/7] lib/ref_tracker: add unlocked leak print helper

From: Eric Dumazet
Date: Fri Apr 21 2023 - 10:25:02 EST


On Fri, Apr 21, 2023 at 1:35 PM Andrzej Hajda <andrzej.hajda@xxxxxxxxx> wrote:
>
> To have reliable detection of leaks, caller must be able to check under the same
> lock both: tracked counter and the leaks. dir.lock is natural candidate for such
> lock and unlocked print helper can be called with this lock taken.
> As a bonus we can reuse this helper in ref_tracker_dir_exit.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> ---

SGTM, thanks.

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>