Re: [PATCH v8 2/8] dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY

[Dmitry Baryshkov]

On 21/04/2023 13:13, Varadarajan Narayanan wrote:
> On Thu, Apr 06, 2023 at 09:42:31AM +0200, Krzysztof Kozlowski wrote:
> > On 05/04/2023 13:41, Varadarajan Narayanan wrote:
> > > Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574
> > >
> > > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> > > ---
> > >   Changes in v8:
> > > 	- Update clock names for ipq9574
> > >
> > >   Changes in v6:
> > > 	- Made power-domains optional
> > >
> > > Note: In the earlier patch sets, had used the (legacy)
> > > specification available in qcom,msm8996-qmp-usb3-phy.yaml. Moved
> > > to newer specification in qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> > > ---
> > >   .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml        | 43 +++++++++++++++++++---
> > >   1 file changed, 37 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> > > index 16fce10..e902a0d 100644
> > > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> > > @@ -16,6 +16,7 @@ description:
> > >   properties:
> > >     compatible:
> > >       enum:
> > > +      - qcom,ipq9574-qmp-usb3-phy
> > >         - qcom,sc8280xp-qmp-usb3-uni-phy
> > >
> > >     reg:
> > > @@ -25,11 +26,7 @@ properties:
> > >       maxItems: 4
> > >
> > >     clock-names:
> > > -    items:
> > > -      - const: aux
> > > -      - const: ref
> > > -      - const: com_aux
> > > -      - const: pipe
> > > +    maxItems: 4
> > >
> > >     power-domains:
> > >       maxItems: 1
> > > @@ -60,7 +57,6 @@ required:
> > >     - reg
> > >     - clocks
> > >     - clock-names
> > > -  - power-domains
> >
> > Power domains are required. Commit msg does not explain why this should
> > be now optional.
>
> Since IPQ9574 doesn't have power switches couldn't provide power-domains details.
> So, had to make it optional to pass 'make dtbs_check'.

This should be a part of the commit message, so that the next developer 
understands your intentions without going to mail archives.

> Thanks
> Varada
>
> > Best regards,
> > Krzysztof

--
With best wishes
Dmitry