Re: [PATCH] media: v4l2-mc: Drop subdev check in v4l2_create_fwnode_links_to_pad()

From: Sakari Ailus
Date: Fri Apr 21 2023 - 08:17:26 EST


On Fri, Apr 21, 2023 at 03:10:48PM +0300, Laurent Pinchart wrote:
> Hi Vaishnav,
>
> Thank you for the patch.
>
> On Fri, Apr 21, 2023 at 03:34:30PM +0530, Vaishnav Achath wrote:
> > While updating v4l2_create_fwnode_links_to_pad() to accept non-subdev
> > sinks, the check is_media_entity_v4l2_subdev() was not removed which
> > prevented the function from being used with non-subdev sinks, Drop the
> > unnecessary check.
> >
> > Fixes: bd5a03bc5be8 ("media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad()")
> >
> > Signed-off-by: Vaishnav Achath <vaishnav.a@xxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> Sakari, the commit this patch fixes will land in v6.4, should this be
> merged as a v6.4 fix ?

I'd think so. I'll take this soonish.

--
Sakari Ailus