Re: [PATCH linux-next v2] mm: workingset: update description of the source file

From: Yang Yang
Date: Fri Apr 21 2023 - 07:31:39 EST


> I'm late but FWIW, not supper happy that while the updated calculations are
> now accurate wrt the actual code, the explanation (which was written at the
> time of page cache-only workinset) was more easier to follow in the simpler
> form. Now it's still mostly talking about page cache and explaining the
>balance between its active and inactive list only, and then suddenly the
> anon lists appear out of nowhere in the final equations.

Thanks for your reviewing! I should update the whole parts. Sorry for
hadn't do it better, please drop the patch, I will try to submit patchv3
to fix this.

> In other words, I think it would have been better to leave that explanation
> as it was, and then add a new part describing the extension to anon pages.

I read the description of the source file again carefully, and think that
there is no need to creat a new part, if we explain at the begining that
the word 'pages' include page cache and anonymous page, and do some minor
adjustments. For example:
Per node, two kinds of clock lists are maintained for pages..