Re: [PATCH v3 1/2] gpio: 104-dio-48e: Implement struct dio48e_gpio

From: Linus Walleij
Date: Fri Apr 21 2023 - 04:21:34 EST


On Tue, Apr 11, 2023 at 11:35 PM William Breathitt Gray
<william.gray@xxxxxxxxxx> wrote:
> On Tue, Apr 11, 2023 at 10:15:54PM +0100, Mark Brown wrote:
> > On Tue, Apr 11, 2023 at 02:36:23PM -0400, William Breathitt Gray wrote:
> > > On Tue, Apr 11, 2023 at 09:23:55PM +0100, Mark Brown wrote:
> > > > On Mon, Mar 20, 2023 at 10:50:15AM -0400, William Breathitt Gray wrote:
> > > > > A private data structure struct dio48e_gpio is introduced to facilitate
> > > > > passage of the regmap and IRQ mask state for the device to the callback
> > > > > dio48e_handle_mask_sync(). This is in preparation for the removal of the
> > > > > handle_mask_sync() map parameter in a subsequent patch.
> >
> > > > What's the story with this patch?
> >
> > > Currently dio48e_handle_mask_sync() uses the map argument in its
> > > implementation. Once the map parameter is removed, the current
> > > implementation of dio48e_handle_mask_sync() will no longer build, so we
> > > must adjust the implementation to no longer depend on map.
> >
> > I mean what's the story with getting this patch applied? It doesn't
> > seem to have been reviewed...
>
> I'm sorry, I forgot to add Linus' tag from v2 [0]. Linus, would you
> confirm you're still okay with this patch?

Oh of course.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij