RE: [PATCH v4 6/6] x86/hyperv: Fix serial console interrupts for TDX guests

From: Dexuan Cui
Date: Thu Apr 20 2023 - 23:54:19 EST


> From: Michael Kelley (LINUX) <mikelley@xxxxxxxxxxxxx>
> Sent: Tuesday, April 11, 2023 10:14 AM
> > ...
> > + * Copy arch/x86/kernel/acpi/boot.c: acpi_generic_reduced_hw_init() but
> > doesn't change 'legacy_pic', so it keeps its default value 'default_legacy_pic' in
> > + * mp_config_acpi_legacy_irqs(), which sees a non-zero nr_legacy_irqs(),
> > and eventually serial console interrupts can work properly.
>
> I had a little trouble parsing this comment. Slightly better wording is:
>
> * Clone arch/x86/kernel/acpi/boot.c: acpi_generic_reduced_hw_init()
> here,
> * except don't change 'legacy_pic'. It keeps its default value
> 'default_legacy_pic'.
> * mp_config_acpi_legacy_irqs() sees a non-zero nr_legacy_irqs(), and
> * eventually serial console interrupts can work properly.
>
> Otherwise,
>
> Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>

Thanks! Will use this in v5.