Re: [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency

From: Christian Marangi
Date: Thu Apr 20 2023 - 17:54:36 EST


On Thu, Apr 20, 2023 at 11:36:31PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> With LEDS_CLASS=m, a built-in qca8k driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
> qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'
>
> Change the dependency to avoid the broken configuration.
>
> Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks a lot for the fix and sorry for the mess...
LED_CLASS and PHY releated were really hell also for some reason this
didn't got flagged in month of this series.

Again thanks for handling this!

--
Ansuel