Re: [PATCH v2 2/2] vfs: clean up d_backing_inode() function

From: Al Viro
Date: Thu Apr 20 2023 - 16:46:07 EST


On Wed, Apr 19, 2023 at 10:47:04AM +0000, Haifeng Xu wrote:
> d_backing_inode() does the same thing with d_inode(), so using
> d_inode() to get the inode of dentry instead of d_backing_inode().
>
> Signed-off-by: Haifeng Xu <haifeng.xu@xxxxxxxxxx>
> Suggested-by: Miklos Szeredi <mszeredi@xxxxxxxxxx>

Fine by me, but generally that kind of search-and-replace is
better done differently:

1) patch replacing the definition of d_backing_inode() with
#define d_backing_inode d_inode

2) mail to Linus, asking to do mechanical search-and-replace
just prior to -rc1; see e.g. 7c0f6ba682b9 for example of
that being done. In this case the script would be
sed -i -e "s/\<d_backing_inode\>/d_inode/g" $(git grep -l -w "d_backing_inode")
sed -i -e "/#define d_inode d_inode/d" include/linux/dentry.h