Re: [PATCH V3 1/2] dt-bindings: interrupt-controller: Add Loongson EIOINTC

From: Krzysztof Kozlowski
Date: Thu Apr 20 2023 - 11:52:30 EST


On 20/04/2023 15:00, Binbin Zhou wrote:
>>> +examples:
>>> + - |
>>> + eiointc: interrupt-controller@1fe11600 {
>>> + compatible = "loongson,ls2k0500-eiointc";
>>> + reg = <0x1fe11600 0x10>,
>>> + <0x1fe11700 0x10>,
>>> + <0x1fe11800 0x10>,
>>> + <0x1fe114c0 0x4>;
>>
>> Binding is OK, but are you sure you want to split the address space like
>> this? It looks like two address spaces (enable+clear+status should be
>> one). Are you sure this is correct?
>>
> Hi Krzysztof:
>
> These registers are all in the range of chip configuration registers,
> in the case of LS2K0500, which has a base address of 0x1fe10000.
> However, the individual register addresses are not contiguous with
> each other, and most are distributed across modules, so I feel that
> they should be listed in detail as they are used.

Do you want to say that:
Between 0x1fe11600 and 0x1fe11700 there are EIOINTC registers and other
(independent) module registers?


Best regards,
Krzysztof