Re: [Resend PATCH] mm: mark folio as workingset in lru_deactivate_fn

From: Matthew Wilcox
Date: Thu Apr 20 2023 - 08:07:19 EST


On Thu, Apr 20, 2023 at 04:45:04PM +0800, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@xxxxxxxxxx>
>
> The folio will be set as workingset by shrink_active_pages during normal reclaiming.
> However, it will be escaped from doing so when madvise move it by lru_deactivate_<file>_fn,
> which will affect accuracy of thrashing.

Why are you resending this? Johannes pointed out that your
understanding of this situation is wrong. The folio is being
made _inactive_. It's clearly no longer part of the working set!