Re: [PATCH 09/10] ARM: dts: qcom: msm8960-cdp: move regulator out of simple-bus

From: Konrad Dybcio
Date: Thu Apr 20 2023 - 06:53:31 EST




On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Regulators is not a bus, so drop incomplete simple-bus usage to fix dtbs
> W=1 warning:
>
> Warning (simple_bus_reg): /regulators/gpio-regulator: missing or empty reg/ranges property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm/boot/dts/qcom-msm8960-cdp.dts | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> index 8fa2befa629a..6c1bc3818883 100644
> --- a/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> +++ b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> @@ -15,16 +15,12 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> - regulators {
> - compatible = "simple-bus";
> -
> - ext_l2: gpio-regulator {
> - compatible = "regulator-fixed";
> - regulator-name = "ext_l2";
> - gpio = <&msmgpio 91 0>;
> - startup-delay-us = <10000>;
> - enable-active-high;
> - };
> + ext_l2: gpio-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "ext_l2";
> + gpio = <&msmgpio 91 0>;
> + startup-delay-us = <10000>;
> + enable-active-high;
> };
> };
>