Re: [PATCH] UHCI：adjust zhaoxin UHCI controllers OverCurrent bit value

[WeitaoWang-oc@xxxxxxxxxxx]

On 2023/4/20 16:05, Greg KH wrote:
> On Thu, Apr 20, 2023 at 07:14:45PM +0800, Weitao Wang wrote:
> > Over Current condition is not standardized in the UHCI spec.
> > Zhaoxin UHCI controllers report OverCurrent bit active off.
> > Intel controllers report it active on, so we'll adjust the bit value.
> >
> > Signed-off-by: Weitao Wang <WeitaoWang-oc@xxxxxxxxxxx>
>
> Note, your Subject: line has odd characters in it, can you rewrite it to
> just use ascii?  I think it's the '：' character which should be ':',
> right?Yes,you are right. it's my typo mistake. I'll rewrite this patch. Thanks!

> > ---
> >   drivers/usb/host/uhci-pci.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/host/uhci-pci.c b/drivers/usb/host/uhci-pci.c
> > index 3592f757fe05..177e3c2aa287 100644
> > --- a/drivers/usb/host/uhci-pci.c
> > +++ b/drivers/usb/host/uhci-pci.c
> > @@ -126,6 +126,10 @@ static int uhci_pci_init(struct usb_hcd *hcd)
> >   	if (to_pci_dev(uhci_dev(uhci))->vendor == PCI_VENDOR_ID_VIA)
> >   		uhci->oc_low = 1;
> >   
> > +	/* ZHAOXIN controllers report OverCurrent bit active off. */
> > +	if (to_pci_dev(uhci_dev(uhci))->vendor == PCI_VENDOR_ID_ZHAOXIN)
> > +		uhci->oc_low = 1;
> > +
>
> This should also go to the stable kernels, right?
>
> But a new UHCI controller?  And this affects all of them? 
All UHCI controller of zhaoxin have this issue, And Hope this
patch go to stable kernel.Could I resubmit this patch with
modify subject typo mistake?

> Intel an issue here (as you mention in the changelog text)?
I got this info from uhci driver comments in function uhci_pci_init.

"Intel controllers report the OverCurrent bit active on.
VIA controllers report it active off, so we'll adjust the
bit value.  (It's not standardized in the UHCI spec.)"

Best Regards,
weitao

> thanks,
>
> greg k-h
> .