Re: [PATCH 3/5] leds: trigger: netdev: rename add namespace to netdev trigger enum modes

[Andrew Lunn]

On Wed, Apr 19, 2023 at 11:07:41PM +0200, Christian Marangi wrote:
> Rename NETDEV trigger enum modes to a more symbolic name and add a
> namespace to them.
> 
> Also add __TRIGGER_NETDEV_MAX to identify the max modes of the netdev
> trigger.
> 
> This is a cleanup to drop the define and no behaviour change are
> intended.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
>  
>  static ssize_t netdev_led_attr_show(struct device *dev, char *buf,
> -	enum netdev_led_attr attr)
> +				    enum led_trigger_netdev_modes attr)
>  {
> @@ -169,7 +165,7 @@ static ssize_t netdev_led_attr_show(struct device *dev, char *buf,
>  }
>  
>  static ssize_t netdev_led_attr_store(struct device *dev, const char *buf,
> -	size_t size, enum netdev_led_attr attr)
> +				     size_t size, enum led_trigger_netdev_modes attr)

These whitespace changes should not really be in this patch. But...

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew