Re: [PATCH v3 0/8] objtool: warning improvements

From: Miroslav Benes
Date: Wed Apr 19 2023 - 10:51:56 EST


On Tue, 18 Apr 2023, Josh Poimboeuf wrote:

> v3:
> - dropped merged patches and rebased on tip/objtool/core
> - moved list of noreturn functions to separate file
> - improved WARN_INSN() to do single evaluation of insn arg
>
> Josh Poimboeuf (8):
> objtool: Limit unreachable warnings to once per function
> objtool: Add verbose option for disassembling affected functions
> objtool: Include backtrace in verbose mode
> objtool: Detect missing __noreturn annotations
> objtool: Ignore exc_double_fault() __noreturn warnings
> objtool: Remove superfluous global_noreturns entries
> tools/lib/subcmd: Replace NORETURN usage with __noreturn
> objtool: Move noreturn function list to separate file
>
> tools/lib/subcmd/parse-options.h | 8 +-
> tools/lib/subcmd/subcmd-util.h | 5 +-
> tools/objtool/Documentation/objtool.txt | 10 ++
> tools/objtool/builtin-check.c | 5 +
> tools/objtool/check.c | 195 ++++++++++++++++--------
> tools/objtool/include/objtool/builtin.h | 1 +
> tools/objtool/include/objtool/elf.h | 1 +
> tools/objtool/include/objtool/warn.h | 21 ++-
> tools/objtool/noreturns.h | 45 ++++++
> 9 files changed, 214 insertions(+), 77 deletions(-)
> create mode 100644 tools/objtool/noreturns.h

Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>

M