Re: [PATCH v2 5/9] regulator: rt5033: Change regulator names to lowercase

From: Krzysztof Kozlowski
Date: Wed Apr 19 2023 - 04:40:09 EST


On 18/04/2023 23:24, Jakob Hauser wrote:
> Hi Krzysztof,
>
> On 16.04.23 20:32, Krzysztof Kozlowski wrote:
>> On 16/04/2023 14:44, Jakob Hauser wrote:
>>> Lowercase is preferred for node names.
>>
>> This will break all existing users. In-tree and out-of-tree. Where is
>> the binding update?
>
> In my reply to Rob's comments in v1 I was pointing out that this will
> affect an existing driver. There was no reaction.
>
> As far as I can see, there is no in-tree usage yet. Though I can't tell
> about out-of-tree usage. Although if there is, adding the rt5033-charger
> driver might already causes the need for changes.
>
> Well, to stay on the safe side, I'll drop this patch in v3 and will
> change the bindings (patch 9) back to uppercase.
>

Your v1 binding patch did not explain that you document existing ABI, so
you got comments like for a new binding. This is not really new binding,
is it?

Best regards,
Krzysztof