[PATCH v2] net: amd: Fix link leak when verifying config failed

From: Gencen Gan
Date: Wed Apr 19 2023 - 02:59:55 EST


From: Gan Gecen <gangecen@xxxxxxxxxxx>

After failing to verify configuration, it returns directly without
releasing link, which may cause memory leak.

Signed-off-by: Gan Gecen <gangecen@xxxxxxxxxxx>
---
v1->v2: Fix the whitespace-damaged bug.
drivers/net/ethernet/amd/nmclan_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
index 823a329a921f..0dd391c84c13 100644
--- a/drivers/net/ethernet/amd/nmclan_cs.c
+++ b/drivers/net/ethernet/amd/nmclan_cs.c
@@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link)
} else {
pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",
sig[0], sig[1]);
- return -ENODEV;
+ goto failed;
}
}

--
2.34.1