Re: [PATCH net v3] net: ethernet: fix use after free bug in ns83820_remove_one due to race condition

From: Zheng Hacker
Date: Wed Apr 19 2023 - 01:30:22 EST


Jakub Kicinski <kuba@xxxxxxxxxx> 于2023年4月19日周三 12:33写道:
>
> On Mon, 17 Apr 2023 09:31:07 +0800 Zheng Wang wrote:
> > + netif_carrier_off(ndev);
> > + netif_tx_disable(ndev);
> > +
> > unregister_netdev(ndev
>
> It's not immediately obvious to me why disabling carrier and tx
> are supposed to help. Please elaborate in the commit message if
> you're confident that this is right.
>

Hi Jakub,

Thanks for your reply. I'll figure it out to see if it's really necessary.

Best regards,
Zheng

> --
> pw-bot: cr