Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt

From: Bjorn Helgaas
Date: Tue Apr 18 2023 - 14:40:11 EST


On Tue, Apr 18, 2023 at 11:10:39AM -0700, Florian Fainelli wrote:
> On 4/18/23 10:43, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> >
> > Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
> > match other PCIe drivers. Capitalize "Meson" to match other Meson Kconfig
> > prompts.
>
> Did you mean, do not capitalize "Meson" or did you intend to preserve the
> previous hunk that had "Meson" capitalized?

I made it match other Meson prompts:

arch/arm/mach-meson/Kconfig- bool "Amlogic Meson6 (8726MX) SoCs support"
drivers/char/hw_random/Kconfig- tristate "Amlogic Meson Random Number Generator support"
drivers/clk/meson/Kconfig- bool "Meson8 SoC Clock controller support"
drivers/gpu/drm/meson/Kconfig- tristate "DRM Support for Amlogic Meson Display Controller"
drivers/i2c/busses/Kconfig- tristate "Amlogic Meson I2C controller"
drivers/iio/adc/Kconfig- tristate "Amlogic Meson SAR ADC driver"
drivers/media/cec/platform/Kconfig- tristate "Amlogic Meson AO CEC driver"

So I guess could have described as "style Meson with initial cap only
instead of all caps" or something.

Bjorn