Re: [PATCH] module: stats: fix invalid_mod_bytes typo

From: Luis Chamberlain
Date: Tue Apr 18 2023 - 11:40:46 EST


On Tue, Apr 18, 2023 at 09:17:51AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> This was caught by randconfig builds but does not show up in
> build testing without CONFIG_MODULE_DECOMPRESS:
>
> kernel/module/stats.c: In function 'mod_stat_bump_invalid':
> kernel/module/stats.c:229:42: error: 'invalid_mod_byte' undeclared (first use in this function); did you mean 'invalid_mod_bytes'?
> 229 | atomic_long_add(info->compressed_len, &invalid_mod_byte);
> | ^~~~~~~~~~~~~~~~
> | invalid_mod_bytes
>
> Fixes: 0d4ab68ce983 ("module: add debug stats to help identify memory pressure")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> This was probably already reported, sending the fix just in case everyone
> else else missed it so far.

Oh it was a decompression ifdef, that's why I didn't catch it! But also
I guess 0-day isn't running tests with it enabled either!

Thanks! Applied and pushed!

Luis