Re: [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock

From: Konrad Dybcio
Date: Mon Apr 17 2023 - 10:34:52 EST




On 17.04.2023 12:56, Kathiravan T wrote:
> The order of DT_SLEEP_CLK and DT_XO are swapped and it is incorrect.
> Due to which the clocks for which the parent should be XO is having parent
> as SLEEP_CLK and vice versa. So fix the same by re-ordering the entries.
>
> Fixes: 3d89d52970fd ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC")
> Reported-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> Signed-off-by: Kathiravan T <quic_kathirav@xxxxxxxxxxx>
> ---
This matches what I can see in the bindings.

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> Changes in V2:
> - Added the Reported-by and Fixes tag
>
> drivers/clk/qcom/gcc-ipq5332.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
> index 8cacbfb10c72..14096887d436 100644
> --- a/drivers/clk/qcom/gcc-ipq5332.c
> +++ b/drivers/clk/qcom/gcc-ipq5332.c
> @@ -20,8 +20,8 @@
> #include "reset.h"
>
> enum {
> - DT_SLEEP_CLK,
> DT_XO,
> + DT_SLEEP_CLK,
> DT_PCIE_2LANE_PHY_PIPE_CLK,
> DT_PCIE_2LANE_PHY_PIPE_CLK_X1,
> DT_USB_PCIE_WRAPPER_PIPE_CLK,