Re: [PATCH v3 7/7] mm/gup: remove vmas array from internal GUP functions

From: David Hildenbrand
Date: Mon Apr 17 2023 - 07:42:19 EST


On 15.04.23 14:09, Lorenzo Stoakes wrote:
Now we have eliminated all callers to GUP APIs which use the vmas
parameter, eliminate it altogether.

This eliminates a class of bugs where vmas might have been kept around
longer than the mmap_lock and thus we need not be concerned about locks
being dropped during this operation leaving behind dangling pointers.

This simplifies the GUP API and makes it considerably clearer as to its
purpose - follow flags are applied and if pinning, an array of pages is
returned.

Signed-off-by: Lorenzo Stoakes <lstoakes@xxxxxxxxx>
---

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb