Re: [PATCH 6/6] arm64: dts: qcom: sm6125-sprout: align ADC channel node names with bindings

From: Konrad Dybcio
Date: Mon Apr 17 2023 - 03:32:39 EST




On 16.04.2023 14:37, Krzysztof Kozlowski wrote:
> Bindings expect ADC channel node names to follow specific pattern:
>
> sm6125-xiaomi-laurel-sprout.dtb: adc@3100: 'adc-chan@4d', 'adc-chan@4e', 'adc-chan@52', 'adc-chan@54' do not match any of the regexes: ...
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
> index b1038eb8cebc..a7f4aeae9c1a 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
> @@ -138,7 +138,7 @@ &pm6125_adc {
> pinctrl-names = "default";
> pinctrl-0 = <&camera_flash_therm &emmc_ufs_therm>;
>
> - adc-chan@4d {
> + channel@4d {
> reg = <ADC5_AMUX_THM1_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> @@ -146,7 +146,7 @@ adc-chan@4d {
> label = "rf_pa0_therm";
> };
>
> - adc-chan@4e {
> + channel@4e {
> reg = <ADC5_AMUX_THM2_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> @@ -154,7 +154,7 @@ adc-chan@4e {
> label = "quiet_therm";
> };
>
> - adc-chan@52 {
> + channel@52 {
> reg = <ADC5_GPIO1_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> @@ -162,7 +162,7 @@ adc-chan@52 {
> label = "camera_flash_therm";
> };
>
> - adc-chan@54 {
> + channel@54 {
> reg = <ADC5_GPIO3_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;