Re: [PATCH 2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback

From: Konrad Dybcio
Date: Mon Apr 17 2023 - 03:16:48 EST




On 16.04.2023 17:13, Krzysztof Kozlowski wrote:
> Since commit 6c84bbd103d8 ("dt-bindings: arm-smmu: Add generic
> qcom,smmu-500 bindings") the SMMU is supposed to use qcom,smmu-500
> compatible fallback:
>
> ['qcom,sm8150-smmu-500', 'qcom,adreno-smmu', 'qcom,smmu-500', 'arm,mmu-500'] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 3846f5e0f656..024b3c79ea11 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -3983,7 +3983,7 @@ spmi_bus: spmi@c440000 {
> };
>
> apps_smmu: iommu@15000000 {
Are you..

> - compatible = "qcom,sm8150-smmu-500", "arm,mmu-500";
> + compatible = "qcom,sm8150-smmu-500",

"qcom,adreno-smmu", "arm,mmu-500";
..sure about that?

Konrad
> reg = <0 0x15000000 0 0x100000>;
> #iommu-cells = <2>;
> #global-interrupts = <1>;