Re: [PATCH net] virtio-net: reject small vring sizes

[Alvaro Karsz]

> > +static int virtnet_validate_vqs(struct virtnet_info *vi)
> > +{
> > +     u32 i, min_size = roundup_pow_of_two(MAX_SKB_FRAGS + 2);
> 
> why power of two?

The ring size is always a power of 2, so checking against MAX_SKB_FRAGS + 2 or against roundup_pow_of_two will result in the same, and I think that printing the warning with the actual min value is more helpful.
I can check the condition against MAX_SKB_FRAGS + 2, and print the rounded value in case of an error.