Re: [PATCH v2 2/3] iio: add documentation for iio_chan_info_enum

From: Jonathan Cameron
Date: Sun Apr 16 2023 - 09:19:39 EST


On Wed, 12 Apr 2023 11:52:05 +0300
Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:

> On 4/8/23 13:30, Jonathan Cameron wrote:
> > On Sat, 25 Feb 2023 15:55:25 +0200
> > Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
> >
> >> + * @IIO_CHAN_INFO_INT_TIME: Integration time. Time during which the data is
> >> + * accumulated by the device.
> >
> > Unit? (seconds I think).
>
> Holy moly. Thanks for bringing this up now. I just checked this and the
> API doc indeed says clearly and loud the unit is in seconds. This means
> the BU27034 driver as well as the gain-time-scale helper does this
> wrong. I hope you can postpone sending them upstream until this gets
> fixed. I'll try to cook incremental patch on top of the iio/togreg - but
> I am not sure if I can do it today as I need to run after an hour...
> Sorry and thanks!

It's a fix so we have time. This one we'd take even if the driver
had made it to a release, but then we'd manage to annoy people.

Jonathan

>
> Yours,
> -- Matti
>