Re: [PATCH 0/2] tools/nolibc: fork: fix on s390 and add test

From: Willy Tarreau
Date: Sun Apr 16 2023 - 01:33:29 EST


Hi Thomas,

On Sat, Apr 15, 2023 at 11:28:46PM +0200, Thomas Weißschuh wrote:
> The generic fork() implementation in nolibc falls back to the clone()
> syscall. On s390 the first two arguments to clone() are swapped compared
> to other architectures, breaking the implementation in nolibc.
>
> Add a custom implementation of fork() to s390 that works.
>
> While at it also add a testcase for fork().
>
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

Thanks for these. Please always Cc the authors of code you're fixing
(e.g. there could be more subtle details that only the author knows
about). Here I think it's OK, but I've CCed Sven and will add him to
your fix.

Thank you!
Willy