Re: [PATCH v6 0/9] ext4: Convert inode preallocation list to an rbtree

From: Theodore Ts'o
Date: Fri Apr 14 2023 - 23:07:15 EST



On Sat, 25 Mar 2023 13:43:33 +0530, Ojaswin Mujoo wrote:
> This patch series aim to improve the performance and scalability of
> inode preallocation by changing inode preallocation linked list to an
> rbtree. I've ran xfstests quick on this series and plan to run auto group
> as well to confirm we have no regressions.
>
> ** Shortcomings of existing implementation **
>
> [...]

Applied, thanks!

[1/9] ext4: Stop searching if PA doesn't satisfy non-extent file
commit: e86a718228b61eef747b8deb446f807b2be73148
[2/9] ext4: Refactor code related to freeing PAs
commit: 820897258ad342e78388ee9f5814fc485e79102a
[3/9] ext4: Refactor code in ext4_mb_normalize_request() and ext4_mb_use_preallocated()
commit: bcf434992145dd08bb5c8d0bd4bf34811e0a5d78
[4/9] ext4: Move overlap assert logic into a separate function
commit: 7692094ac513e48ee37d0f1fb057f3f7f8d53385
[5/9] ext4: Abstract out overlap fix/check logic in ext4_mb_normalize_request()
commit: 0830344c953aeabee91ac88281585756d047df39
[6/9] ext4: Fix best extent lstart adjustment logic in ext4_mb_new_inode_pa()
commit: 93cdf49f6eca5e23f6546b8f28457b2e6a6961d9
[7/9] ext4: Convert pa->pa_inode_list and pa->pa_obj_lock into a union
commit: a8e38fd37cff911638ac288adb138265f71e50c0
[8/9] ext4: Use rbtrees to manage PAs instead of inode i_prealloc_list
commit: 3872778664e36528caf8b27f355e75482f6d562d
[9/9] ext4: Remove the logic to trim inode PAs
commit: 361eb69fc99f1a8f1d653d69ecd742f3cbb896be

Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>