Re: [PATCH 1/3] ARM: compressed: Pass the actual output length to the decompressor

From: Jonathan Neuschäfer
Date: Fri Apr 14 2023 - 21:56:27 EST


On Thu, Apr 13, 2023 at 08:20:50AM +0300, Tony Lindgren wrote:
> * Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> [230412 21:22]:
> > --- a/arch/arm/boot/compressed/misc.c
> > +++ b/arch/arm/boot/compressed/misc.c
> > +static u32 get_inflated_image_size(void)
> > +{
> > + return get_unaligned_le32(input_data_end - 4);
> > +}
>
> Just something to check.. This patch should not picked for the old stable
> kernels that did not have the uncompressed image size at the end. Maybe
> the patch should have a Depends-on tag to prevent possible issues?

As far as I can see, the appended size has been around for a really long
time (v2.6.28, commit bc22c17e12c130dc929218a95aa347e0f3fd05dc), far
longer than the oldest LTS kernel that's still around.

>
> Other than that looks good to me:
>
> Reviewed-by: Tony Lindgren <tony@xxxxxxxxxxx>

Thanks

Jonathan

Attachment: signature.asc
Description: PGP signature