Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state

From: Andrew Morton
Date: Fri Apr 14 2023 - 17:47:13 EST


On Thu, 13 Apr 2023 14:38:03 -0700 Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote:

> > > I suck at naming things. If you think "reclaimed_non_lru" is better,
> > > then we can do that. FWIW mm_account_reclaimed_pages() was taken from
> > > a suggestion from Dave Chinner. My initial version had a terrible
> > > name: report_freed_pages(), so I am happy with whatever you see fit.
> > >
> > > Should I re-spin for this or can we change it in place?
> >
> > I don't care for the noise all the bikeshed painting has generated
> > for a simple change like this. If it's a fix for a bug, and the
> > naming is good enough, just merge it already, ok?
>
> Sorry for all the noise. I think this version is in good enough shape.
>
> Andrew, could you please replace v4 with this v6 without patch 2 as
> multiple people pointed out that it is unneeded? Sorry for the hassle.

I like patch 2!

mm.git presently has the v6 series. All of it ;)