Re: [PATCH v3 6/6] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

From: Robert Richter
Date: Fri Apr 14 2023 - 10:47:22 EST


On 14.04.23 12:55:43, Jonathan Cameron wrote:
> On Fri, 14 Apr 2023 13:21:37 +0200
> Robert Richter <rrichter@xxxxxxx> wrote:

> > The version I have ready after addressing Bjorn's comments is pretty
> > much the same, apart from error checking of the read/writes.
> >
> > From your patch proposed you will need it in aer.c too and we do not
> > need to export it.
>
> I think for the other components we'll want to call it from cxl_pci_ras_unmask()
> so an export needed.
>
> I also wonder if a more generic function would be better as seems likely
> similar code will be needed for errors other than this pair.

There are only a few masked by default, but not only internals. Will
consider that and also make it easy to export later once needed.

Thanks,

-Robert