[PATCH v6 1/3] sched/core: warn on call put_task_struct in invalid context

From: Wander Lairson Costa
Date: Fri Apr 14 2023 - 08:57:06 EST


Under PREEMPT_RT, spinlocks become sleepable locks. put_task_struct()
indirectly acquires a spinlock. Therefore, it can't be called in
atomic/interrupt context in RT kernels.

To prevent such conditions, add a check for atomic/interrupt context
before calling put_task_struct().

Signed-off-by: Wander Lairson Costa <wander@xxxxxxxxxx>
Suggested-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
---
include/linux/sched/task.h | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 357e0068497c..b597b97b1f8f 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -113,14 +113,28 @@ static inline struct task_struct *get_task_struct(struct task_struct *t)

extern void __put_task_struct(struct task_struct *t);

+#define PUT_TASK_RESCHED_OFFSETS \
+ (rcu_preempt_depth() << MIGHT_RESCHED_RCU_SHIFT)
+
+#define __put_task_might_resched() \
+ __might_resched(__FILE__, __LINE__, PUT_TASK_RESCHED_OFFSETS)
+
+#define put_task_might_resched() \
+ do { \
+ if (IS_ENABLED(CONFIG_PREEMPT_RT)) \
+ __put_task_might_resched(); \
+ } while (0)
+
static inline void put_task_struct(struct task_struct *t)
{
+ put_task_might_resched();
if (refcount_dec_and_test(&t->usage))
__put_task_struct(t);
}

static inline void put_task_struct_many(struct task_struct *t, int nr)
{
+ put_task_might_resched();
if (refcount_sub_and_test(nr, &t->usage))
__put_task_struct(t);
}
--
2.39.2