Re: [PATCH V3 1/3] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM

From: Souradeep Chowdhury
Date: Fri Apr 14 2023 - 08:24:22 EST




On 4/13/2023 10:11 PM, Krzysztof Kozlowski wrote:
On 13/04/2023 11:28, Souradeep Chowdhury wrote:

Thank you for your patch. There is something to discuss/improve.

+ "^stats@[0-9a-f]+$":
+ type: object
+ description:
+ Imem region dedicated for storing timestamps related
+ information regarding bootstats.
+
+ properties:
+ compatible:
+ items:
+ - enum:
+ - qcom,sm8450-bootstats
+ - const: qcom,imem-bootstats
+
+ reg:
+ maxItems: 1
+
+ required:
+ - compatible
+ - reg
+
+ additionalProperties: false

The feedback about additionalProperties was given in different place. On
purpose, because it is easier to read when it is placed before
properties for indented cases. Therefore move it after description, how
I originally asked.

Ack


+
required:
- compatible
- reg

Best regards,
Krzysztof