Re: [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs.

From: Takashi Iwai
Date: Fri Apr 14 2023 - 05:39:33 EST


On Fri, 14 Apr 2023 10:50:55 +0200,
ReaperLi wrote:
>
> From: jasontao <jasontao@xxxxxxxxxxx>
>
> Add a set of HD Audio PCI IDS, and the HDMI codec vendor IDs for
> Glenfly Arise.
>
> Signed-off-by: jasontao <jasontao@xxxxxxxxxxx>

Your Signed-off-by tag seems missing. The person who submitted the
patch must give the own Signed-off-by tag. That's a legal
requirement.

Moreover, the patch doesn't seem applicable with git-am. Please fix
your mailer setup to stop mangling tabs with spaces.
At best, use git-send-email for submission.

If anything else can't work, use a mail attachment as a last resort.

The code change itself looks good to me. Please resubmit for the
above points.


thanks,

Takashi