Re: [PATCH v3 3/6] PCI/AER: Export cper_print_aer() for use by modules

From: Jonathan Cameron
Date: Thu Apr 13 2023 - 12:13:53 EST


On Tue, 11 Apr 2023 13:02:59 -0500
Terry Bowman <terry.bowman@xxxxxxx> wrote:

> The CXL driver plans to use cper_print_aer() for restricted CXL host
> (RCH) logging. cper_print_aer() is not exported and as a result is not
> available to the CXL driver or other loadable modules. Export
> cper_print_aer() making it available to CXL and other loadable modules.
>
> Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx>
> Cc: Mahesh J Salgaonkar <mahesh@xxxxxxxxxxxxx>
> Cc: "Oliver O'Halloran" <oohall@xxxxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx
Seems reasonable.
FWIW
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

> ---
> drivers/pci/pcie/aer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index f6c24ded134c..7a25b62d9e01 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -812,6 +812,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity,
> trace_aer_event(dev_name(&dev->dev), (status & ~mask),
> aer_severity, tlp_header_valid, &aer->header_log);
> }
> +EXPORT_SYMBOL_GPL(cper_print_aer);
> #endif
>
> /**