Re: [PATCH v3 00/21] Update uncore topics, 1x event updates, 2x new archs.

From: Arnaldo Carvalho de Melo
Date: Thu Apr 13 2023 - 10:04:20 EST


Em Thu, Apr 13, 2023 at 06:29:28AM -0700, Ian Rogers escreveu:
> Update the uncore PMUs and topic classification as created by:
> https://github.com/intel/perfmon/pull/70
>
> Event updates stem from:
> https://github.com/intel/perfmon/pull/68
> impacting alderlake, icelakex and sapphirerapids.
>
> Grand Ridge and Sierra Forest events stem from:
> https://github.com/intel/perfmon/pull/69
>
> Changes generated by with PR70 in place:
> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
>
> v3. Rebase over the update of alderlake and icelakex events.
> v2. Adds improvements to uncore topics, uncore PMU name fixes and
> fixes a trigraph issue from ??? being in the json.

b4 isn't liking it:

⬢[acme@toolbox perf-tools-next]$ b4 am -ctsl --cc-trailers 20230413132949.3487664-1-irogers@xxxxxxxxxx
Grabbing thread from lore.kernel.org/all/20230413132949.3487664-1-irogers%40google.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 14 messages in the thread
Checking attestation on all messages, may take a moment...
---
ERROR: missing [1/21]!
✓ [PATCH v3 2/21] perf vendor events intel: Add grandridge
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 3/21] perf vendor events intel: Add sierraforest
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 4/21] perf vendor events intel: Fix uncore topics for alderlake
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 5/21] perf vendor events intel: Fix uncore topics for broadwell
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 6/21] perf vendor events intel: Fix uncore topics for broadwellde
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [7/21]!
ERROR: missing [8/21]!
✓ [PATCH v3 9/21] perf vendor events intel: Fix uncore topics for haswell
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [10/21]!
✓ [PATCH v3 11/21] perf vendor events intel: Fix uncore topics for icelake
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [12/21]!
✓ [PATCH v3 13/21] perf vendor events intel: Fix uncore topics for ivybridge
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [14/21]!
✓ [PATCH v3 15/21] perf vendor events intel: Fix uncore topics for jaketown
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 16/21] perf vendor events intel: Fix uncore topics for knightslanding
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 17/21] perf vendor events intel: Fix uncore topics for sandybridge
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 18/21] perf vendor events intel: Fix uncore topics for skylake
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [19/21]!
ERROR: missing [20/21]!
✓ [PATCH v3 21/21] perf vendor events intel: Fix uncore topics for tigerlake
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
---
Total patches: 13
---
WARNING: Thread incomplete!
Cover: ./v3_20230413_irogers_update_uncore_topics_1x_event_updates_2x_new_archs.cover
Link: https://lore.kernel.org/r/20230413132949.3487664-1-irogers@xxxxxxxxxx
Base: not specified
git am ./v3_20230413_irogers_update_uncore_topics_1x_event_updates_2x_new_archs.mbx
⬢[acme@toolbox perf-tools-next]$


Lemme try to update it to see if it copes... nope:

⬢[acme@toolbox b4]$ git pull
Updating 041d10b7f628fa08..00303592f25693cb
Fast-forward
b4/__init__.py | 54 ++++++++++++++++++++++++++++++++----------------------
b4/command.py | 4 ++--
b4/ez.py | 15 ++++++++++++---
b4/ty.py | 10 ++++++----
docs/config.rst | 19 +++++++++++++++++++
man/b4.5 | 6 +++++-
man/b4.5.rst | 2 ++
tests/samples/trailers-followup-with-cover-ref-addlink.txt | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/test___init__.py | 1 +
9 files changed, 146 insertions(+), 32 deletions(-)
create mode 100644 tests/samples/trailers-followup-with-cover-ref-addlink.txt
⬢[acme@toolbox b4]$ git diff
⬢[acme@toolbox b4]$ cd -
/var/home/acme/git/perf-tools-next
⬢[acme@toolbox perf-tools-next]$ b4 am -ctsl --cc-trailers 20230413132949.3487664-1-irogers@xxxxxxxxxx
Grabbing thread from lore.kernel.org/all/20230413132949.3487664-1-irogers%40google.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 14 messages in the thread
Checking attestation on all messages, may take a moment...
---
ERROR: missing [1/21]!
✓ [PATCH v3 2/21] perf vendor events intel: Add grandridge
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-3-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 3/21] perf vendor events intel: Add sierraforest
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-4-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 4/21] perf vendor events intel: Fix uncore topics for alderlake
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-5-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 5/21] perf vendor events intel: Fix uncore topics for broadwell
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-6-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 6/21] perf vendor events intel: Fix uncore topics for broadwellde
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-7-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [7/21]!
ERROR: missing [8/21]!
✓ [PATCH v3 9/21] perf vendor events intel: Fix uncore topics for haswell
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-10-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [10/21]!
✓ [PATCH v3 11/21] perf vendor events intel: Fix uncore topics for icelake
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-12-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [12/21]!
✓ [PATCH v3 13/21] perf vendor events intel: Fix uncore topics for ivybridge
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-14-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [14/21]!
✓ [PATCH v3 15/21] perf vendor events intel: Fix uncore topics for jaketown
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-16-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 16/21] perf vendor events intel: Fix uncore topics for knightslanding
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-17-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 17/21] perf vendor events intel: Fix uncore topics for sandybridge
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-18-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
✓ [PATCH v3 18/21] perf vendor events intel: Fix uncore topics for skylake
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-19-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
ERROR: missing [19/21]!
ERROR: missing [20/21]!
✓ [PATCH v3 21/21] perf vendor events intel: Fix uncore topics for tigerlake
✓ Signed: DKIM/google.com
+ Link: https://lore.kernel.org/r/20230413132949.3487664-22-irogers@xxxxxxxxxx
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
---
Total patches: 13
---
WARNING: Thread incomplete!
Cover: ./v3_20230413_irogers_update_uncore_topics_1x_event_updates_2x_new_archs.cover
Link: https://lore.kernel.org/r/20230413132949.3487664-1-irogers@xxxxxxxxxx
Base: not specified
git am ./v3_20230413_irogers_update_uncore_topics_1x_event_updates_2x_new_archs.mbx
⬢[acme@toolbox perf-tools-next]$