Re: [PATCH] platform/x86/intel/pmt: Ignore uninitialized entries

From: Ilpo Järvinen
Date: Thu Apr 13 2023 - 06:14:24 EST


On Wed, 12 Apr 2023, David E. Box wrote:

> On Intel Xeon, unused PMT regions will have uninitialized discovery headers
> containing all 0xF. Instead of returning an error, just skip the region.
>
> Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> ---
> drivers/platform/x86/intel/pmt/telemetry.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/telemetry.c b/drivers/platform/x86/intel/pmt/telemetry.c
> index 71cdef42084a..39cbc87cc28a 100644
> --- a/drivers/platform/x86/intel/pmt/telemetry.c
> +++ b/drivers/platform/x86/intel/pmt/telemetry.c
> @@ -78,7 +78,7 @@ static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
> * reserved for future use. They have zero size. Do not fail
> * probe for these. Just ignore them.
> */
> - if (header->size == 0)
> + if (header->size == 0 || header->access_type == 0xF)
> return 1;
>
> return 0;

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>


--
i.