RE: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk

From: Stanley Chang[昌育德]
Date: Thu Apr 13 2023 - 04:05:15 EST



> On 13/04/2023 05:03, Stanley Chang wrote:
> > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for
> > disable the high-speed parkmode.
>
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC. It might happen, that command when run on an older kernel, gives
> you outdated entries. Therefore please be sure you base your patches on
> recent Linux kernel.
>
> It's the second time I am writing it. I don't understand why you keep ignoring
> it.

Sorry for the confusion.
In the beginning I didn't have cc all maintainers.
I'll resubmit a new review thread.
Please ignore this email.

> Your commit msg does not explain why do we need it.

I will add it at new patch.

> >
> > Signed-off-by: Stanley Chang <stanley_chang@xxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > index be36956af53b..45ca967b8d14 100644
> > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > @@ -232,6 +232,11 @@ properties:
> > When set, all SuperSpeed bus instances in park mode are disabled.
> > type: boolean
> >
> > + snps,parkmode-disable-hs-quirk:
> > + description:
> > + When set, all HighSpeed bus instances in park mode are disabled.
>
> Why?
>

For some USB wifi devices, if enable this feature it will reduce the
performance. Therefore, add an option for disabling HS park mode by device-tree.

Thanks,
Stanley