Re: [PATCH 5/5] drm/panel: nt36523: Add Lenovo J606F panel

[Jianhua Lu]

On Wed, Apr 12, 2023 at 09:46:02PM +0200, Konrad Dybcio wrote:
> Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3
> video mode display. Add support for these panels.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-novatek-nt36523.c | 491 ++++++++++++++++++++++++++
>  1 file changed, 491 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> index db4b4af13ec1..4bf9f8db26ba 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> @@ -13,6 +13,8 @@
>  #include <linux/of_graph.h>
>  #include <linux/regulator/consumer.h>
>  
[..] 
> +static const struct panel_desc j606f_boe_desc = {
> +	.modes = j606f_boe_modes,
> +	.num_modes = ARRAY_SIZE(j606f_boe_modes),
> +	.dsi_info = {
> +		.type = "J606F BOE",
> +		.channel = 0,
> +		.node = NULL,
> +	},
The dsi_info just be used to register slave dsi, for single dsi case, can drop
it.

Otherwise looks great, thanks!

Reviewed-by: Jianhua Lu <lujianhua000@xxxxxxxxx>
> +	.width_mm = 143,
> +	.height_mm = 235,
> +	.bpc = 8,
> +	.lanes = 4,
> +	.format = MIPI_DSI_FMT_RGB888,
> +	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> +		      MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
> +	.init_sequence = j606f_boe_init_sequence,
> +	.has_dcs_backlight = true,
> +};
> +
>  static void nt36523_reset(struct panel_info *pinfo)
>  {
>  	gpiod_set_value_cansleep(pinfo->reset_gpio, 1);
> @@ -826,6 +1313,10 @@ static int nt36523_probe(struct mipi_dsi_device *dsi)
>  }
>  
>  static const struct of_device_id nt36523_of_match[] = {
> +	{
> +		.compatible = "lenovo,j606f-boe-nt36523w",
> +		.data = &j606f_boe_desc,
> +	},
>  	{
>  		.compatible = "xiaomi,elish-boe-nt36523",
>  		.data = &elish_boe_desc,
> 
> -- 
> 2.40.0
>