Re: [net-next Patch v7 4/6] octeontx2-pf: Refactor schedular queue alloc/free calls

From: Jacob Keller
Date: Wed Apr 12 2023 - 19:10:57 EST




On 4/10/2023 12:29 AM, Hariprasad Kelam wrote:
> Multiple transmit scheduler queues can be configured at different
> levels to support traffic shaping and scheduling. But on txschq free
> requests, the transmit schedular config in hardware is not getting
> reset. This patch adds support to reset the stale config.
>
> The txschq alloc response handler updates the default txschq
> array which is used to configure the transmit packet path from
> SMQ to TL2 levels. However, for new features such as QoS offload
> that requires it's own txschq queues, this handler is still
> invoked and results in undefined behavior. The code now handles
> txschq response in the mbox caller function.

This paragraph is a bit hard to parse. I assume you mean that the
behavior used to be undefined? This could use a little bit of rephrasing.

The code it self seems ok.