Re: [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM

From: Sean Christopherson
Date: Wed Apr 12 2023 - 18:01:48 EST


On Wed, Mar 22, 2023, Michael Roth wrote:
> On Tue, Feb 21, 2023 at 08:11:35PM +0800, Chao Peng wrote:
> > > *fixup (upm_base_support): KVM: use inclusive ranges for restrictedmem binding/unbinding
> > > *fixup (upm_base_support): mm: restrictedmem: use inclusive ranges for issuing invalidations
> >
> > As many kernel APIs treat 'end' as exclusive, I would rather keep using
> > exclusive 'end' for these APIs(restrictedmem_bind/restrictedmem_unbind
> > and notifier callbacks) but fix it internally in the restrictedmem. E.g.
> > all the places where xarray API needs a 'last'/'max' we use 'end - 1'.
> > See below for the change.
>
> Yes I did feel like I was fighting the kernel a bit on that; your
> suggestion seems like it would be a better fit.

Comically belated +1, XArray is the odd one here.